kwin edited a comment on issue #13: SLING-8452 migrate to OSGi annotations URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/13#issuecomment-505790055 > when compiling the models.impl with the branch, the sling-org-apache-sling-models-integration-tests project fails (probably only because the launchpad used for the project is outdated - the impl bundle cannot be deployed). this would be a good additional test for this branch. Thanks for that hint, this was due to a missing service implementation. The diff tool at https://github.com/jsedding/osgi-ds-metatype-diff was unfortunately not exposing those differences (https://github.com/jsedding/osgi-ds-metatype-diff/issues/11). I fixed this in https://github.com/apache/sling-org-apache-sling-models-impl/pull/13/commits/761bd9c91a66dcd61b14b156496ff3b1514fbd92
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
