On Wed, 2019-07-03 at 17:00 +0200, Andrei Dulvac wrote: > Forking. > > thanks for noticing this. No, I don't think we need to expose the > package > (in the future) and I'm not sure where the version increase is coming > from > since the config of maven-bundle-plugin does not export it. And > there's no > package-info.json. So either a misconfiguration (likely) or a bug?
The maven-bundle-plugin defaults to the project's version if a package is exported without a specific version. Robert > - Andrei > > On Wed, Jul 3, 2019 at 4:34 PM Radu Cotescu <[email protected]> wrote: > > > +1 (checked signatures and build) > > > > JIRA release is at > > https://issues.apache.org/jira/projects/SLING/versions/12343354. > > > > One nitpick, which can obviously be solved with the next release: > > > > [INFO] org.apache.sling.testing.clients.query.servlet unchang > > ed > > 1.2.2 1.2.0 1.2.0 Version has been increased but > > analysis > > detected no changes > > [INFO] - version 1.2.0 > > [INFO] + version 1.2.2 > > > > Do we really need to expose this package? > > > > Cheers, > > Radu > > > > > On 3 Jul 2019, at 15:17, Andrei Dulvac <[email protected]> wrote: > > > > > > Hi all. > > > > > > I'd like to call a vote for releasing Apache Sling Testing > > > Clients 1.2.2 > > > (last release a year ago) > > > > > > We solved 4 issues in this release > > > https://issues.apache.org/jira/browse/SLING-8227 > > > https://issues.apache.org/jira/browse/SLING-8160 > > > https://issues.apache.org/jira/browse/SLING-7724 > > > https://issues.apache.org/jira/browse/SLING-7680 > > > > > > Staging repository: > > > https://repository.apache.org/content/repositories/orgapachesling-2104/ > > > > > > You can use this UNIX script to download the release and verify > > > the > > > signatures: > > > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > > > > > Usage: > > > sh check_staged_release.sh 2104 /tmp/sling-staging > > > > > > Please vote to approve this release: > > > > > > [ ] +1 Approve the release > > > [ ] 0 Don't care > > > [ ] -1 Don't release, because ... > > > > > > This majority vote is open for at least 72 hours.
