Hi all I've implemented these changes, but I had to increase the required java version of JCR Resource to Java 8 (given ZonedDateTime was introduced in Java 8).
Is that ok? Should I create a separate ticket for the Java version increase? And should I increase the bundle version as well, since its compatibility changes? Regards Julian On Thu, Jul 4, 2019 at 6:18 PM Julian Sedding <[email protected]> wrote: > > That should have read: > > 've created SLING-8558 for tracking the change in ValueMapDecorator > (API) and SLING-8559 for tracking the change in JcrValueMap (JCR > Resource) for now. > > Regards > Julian > > On Thu, Jul 4, 2019 at 12:09 PM Julian Sedding <[email protected]> wrote: > > > > Thanks Robert. > > > > I've created SLING-8558 for tracking the change in ValueMapDecorator > > (API) and JcrValueMap (JCR Resource) for now. > > > > Regards > > Julian > > > > On Tue, Jul 2, 2019 at 12:05 PM Robert Munteanu <[email protected]> wrote: > > > > > > On Tue, 2019-07-02 at 12:01 +0200, Julian Sedding wrote: > > > > Hi all > > > > > > > > I think it might make sense to support getting dates from ValueMaps > > > > as > > > > java.time.ZonedDateTime instances directly. I've been finding myself > > > > converting Calendar instances after retrieving them from ValueMaps > > > > quite a bit lately. > > > > > > Sounds good to me. Some notes: > > > > > > - calendar instances also have time zones attached, so we don't > > > introduce anything suprising by returning dates with time zones > > > attached. > > > - we don't bump up the required JVM version as ZonedDateTime is > > > available with Java >= 8. > > > > > > Robert > > >
