[ 
https://issues.apache.org/jira/browse/SLING-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883178#comment-16883178
 ] 

Jason E Bailey commented on SLING-8271:
---------------------------------------

Before pulling this, I think this is a bit limited in scope and could be 
improved with  a Predicate object to determine the ability to descend. In a 
similar way to 
[https://github.com/apache/sling-org-apache-sling-resource-filter/blob/master/src/main/java/org/apache/sling/resource/filter/ResourceStream.java]

You could just extend it to accept(visitor, predicate) and that would allow you 
to define a predicate inline in your source

> Improve AbstractResourceVisitor to allow to stop visiting child resources
> -------------------------------------------------------------------------
>
>                 Key: SLING-8271
>                 URL: https://issues.apache.org/jira/browse/SLING-8271
>             Project: Sling
>          Issue Type: Improvement
>          Components: API
>    Affects Versions: API 2.20.0
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: API 2.20.2
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently the AbstractResourceVisitor 
> (https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/AbstractResourceVisitor.java)
>  completely decouples the {{visit}} method from the actual resource 
> traversal. That means it is currently rather hard to programmatically add a 
> break condition which should lead to no further descending into child 
> resources.
> I propose to extend {{AbstractResourceVisitor}} by an additional visit method 
> which is supposed to return a boolean value. Only if {{true}} is returned it 
> will further descend into the children of the current resource. The default 
> implementation should just return {{true}} to make this change backwards 
> compatible.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to