simonetripodi commented on issue #10: SLING-8578 - Nodes which contain : are not correctly processed URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/10#issuecomment-511112455 thank you so much @andreituicu for this great addition, very appreciated! Just two observations: * there should no need to add an extra path field to the Acl class; * you can invoke `Paths.get(PlatformNameFormat.getRepositoryPath(path)` directly in https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/handlers/RepPolicyEntryHandler.java#L163 Please let me know if you don't have enough spare time to push these small polishing operations, I'll take care of merging your PR then I'll optimise it. Thanks again!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
