bosschaert commented on a change in pull request #13: SLING-8644: Improve
Startorder handling during merge
URL:
https://github.com/apache/sling-org-apache-sling-feature/pull/13#discussion_r315755411
##########
File path: src/main/java/org/apache/sling/feature/builder/BuilderUtil.java
##########
@@ -131,21 +130,22 @@ static void mergeVariables(Map<String,String> target,
Map<String,String> source,
* @throws IllegalStateException If bundles can't be merged, for example
if no
* override is specified for a clash.
*/
- static void mergeBundles(final Bundles target,
- final Bundles source,
+ static void mergeArtifacts(final Artifacts target,
+ final Artifacts source,
final Feature sourceFeature,
final List<ArtifactId> artifactOverrides,
final String originKey) {
for (final Artifact artifactFromSource : source) {
// set of artifacts in target, matching the artifact from source
- final Set<Artifact> allExistingInTarget = new HashSet<>();
+ final Set<Artifact> allExistingInTarget = new LinkedHashSet<>();
Review comment:
Would be good to add a comment to explain why a LinkedHashSet is used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
