I was recently thinking about the way we check releases. We currently have a number of scripts:
- check_staged_release.sh - check_release_matches_tag.sh Also I have my own scripts to check the CI status and build locally. You have proposed a release validator docker image. I would suggest tying thet up together in the following manner. 1. Have a top-level check_sling_release.sh script which drives the whole process 2. Create checks-enabled and checks-available directories The checks-enabled will include 0001_check_staged_release.sh The checks-available will contain all other checks, e.g. 0002_check_release_matches_tag.sh 0003_check_validator_image.sh 0004_check_ci_status.sh 0005_check_local_build.sh Enabling a certain check checks to run then means creating (for example) a symlink from checks- available/0002_check_release_matches_tag.sh to checks-enabled This way we can both accumulate more checks and allow flexibility in which checks are selected. As for the validator image, we can have in the tooling-release repository or a different one, I don't have a strong preference either way. Thanks, Robert On Tue, 2019-08-06 at 09:07 -0400, Daniel Klco wrote: > Sorry for the slow turnaround on this. I updated to use OpenJDK and > rejected the idea of running the integration tests as it makes the > execution time extremely slow. Is this something we'd be interested > in > moving out of the Whiteboard? Unfortunately, it does have quite a > different > structure than the committer-cli due to being mostly bash scripts. > > > On Mon, Jun 17, 2019 at 10:38 AM Robert Munteanu <romb...@apache.org> > wrote: > > > On Thu, 2019-06-13 at 10:49 -0500, Daniel Klco wrote: > > > Yeah, I've gone back and forth regarding the JDK RPM. On the one > > > hand, it'd > > > be better not not require the local RPM, on the other hand, to > > > support > > > validation it'd be good to be able (I would think) to compile > > > against > > > multiple JDK versions and VMs (e.g. Oracle, IBM, whatever) > > > > > > I guess it's a question to the overall team, is there any need to > > > validate > > > against OracleJDK or should I just base this off OpenDJK? > > > > I always used OpenJDK. > > > > Robert > > > > > On Thu, Jun 13, 2019 at 10:29 AM Robert Munteanu < > > > romb...@apache.org> > > > wrote: > > > > > > > Hi Dan, > > > > > > > > On Thu, 2019-06-13 at 10:20 -0500, Daniel Klco wrote: > > > > > I've also been working on a docker image to validate and > > > > > build > > > > > releases: > > > > > > > > > > > > https://github.com/apache/sling-whiteboard/tree/master/release-validator > > > > > It's relatively easy to use > > > > > > > > That looks nice! One question - do you need to have the Java > > > > RPM > > > > locally? If yes, have you considered using one of the OpenJDK > > > > docker > > > > images, which already do this for you? > > > > > > > > https://hub.docker.com/_/openjdk > > > > > > > > As a side note, I have some local scripts which do the > > > > following: > > > > > > > > - check the status of a release on Github > > > > - builds a reactor of the whole > > > > > > > > I am a bit lazy but I'll attach them here, in case you want to > > > > pick > > > > something up for the validator docker image feel free :-) > > > > > > > > Thanks, > > > > > > > > Robert > > > >
