Hi Carsten, hi Dan, A short update: David Gonzalez, who is driving the ACS AEM Commons HTTP Cache project, just confirmed: "once it serves from cache (request or resource include) nothing within that caches response is modifiable(outside transformer pipelines). it just streams that chunk of data to the response."
So I think the ACS AEM Commons HTTP Cache is quite different from my approach and is not what I'm looking for. For now, I'll just continue to work on my code and try to get it to a point, where it's ready to be used in the real world. Let me know if you have any additional input or if you're interested in trying the cache in your environment. Regards, Ben -- Ben Zahler Hit the code jack gmbh | Bergweg 17 | CH-4450 Sissach Phone: +41 79 570 8052 | https://www.hitthecodejack.com/ On 03.09.19, 15:14, "Daniel Klco" <[email protected]> wrote: It looks like Justin Edelson has contributed to some cleanup / fixes to the ACS AEM Commons HTTP Cache. https://github.com/Adobe-Consulting-Services/acs-aem-commons/commits/master?before=9350d397ecc3269fbcc0660ab98dd640388ff649+35&path%5B%5D=bundle&path%5B%5D=src&path%5B%5D=main&path%5B%5D=java&path%5B%5D=com&path%5B%5D=adobe&path%5B%5D=acs&path%5B%5D=commons&path%5B%5D=httpcache On Tue, Sep 3, 2019 at 7:46 AM Carsten Ziegeler <[email protected]> wrote: > At a high level this PoC looks similar to > > > https://adobe-consulting-services.github.io/acs-aem-commons/features/http-cache/index.html > > I think it would be good to talk with the people behind that project and > maybe team up to get a single great solution in Sling > > Regards > Carsten > > Am 03.09.2019 um 09:41 schrieb Carsten Ziegeler: > > Hi Ben, > > > > I like the fact that it does not require changes in Sling as this means > > it can be used as an add on. Using filters should not add more overhead > > than using any other approach more baked into the Sling engine, so from > > that perspective I think the solution is fine as well. > > > > If there are requirements to get more information about the request like > > gzip compression that you mention, we should find a good way to pass the > > info to the place where it is needed. Maybe it makes sense to get a list > > of these things and find out how we can handle it > > > > Regards > > Carsten > > > > Am 02.09.2019 um 23:15 schrieb Ben Zahler: > >> Hi Carsten, > >> Yes, at least for now, I'm completely relying on filters. > >> I think that approach should work, but there are a few cases where > >> additional information from sling could help (for example detecting > >> that gzip compression is applied). I have not looked into that in > detail. > >> > >> That said, unfortunately, I am not familiar with the implementation of > >> the sling engine, so I don't know if my approach is the best possible > >> option. > >> > >> Regards, > >> Ben > >> > > > > -- > -- > Carsten Ziegeler > Adobe Research Switzerland > [email protected] >
