On Friday, September 27, 2019 5:21:03 PM CEST Radu Cotescu wrote: > Hi Olli,
Hi Radu, > > On 27 Sep 2019, at 11:20, Oliver Lietz <[email protected]> wrote: > > > > Please vote to approve this release: > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because … > > I would have loved to spend more time on [0] before cutting a release. It > feels like the implementation was rushed, Why do you think so? Can you explain? > although the issue was open for > four years. There’s also no extra documentation added at [1] about how [0] > can be used by developers. > > Unfortunately I’m away for the next 3 weeks - do you think [0] could wait > until then? The current implementation is the minimal to start with and was carefully added. The new feature doesn't change the existing behavior and doesn't expose a new public API. The TODO mentioned by Stefan explains the design. More implementation - taking language version and engine into account - is still missing because I'm investigating on a semantic version parser *and* there is most probably no demand (I'm not aware of an engine supporting more than one language version properly). As you might have noticed I improved the scripting documentation and I'm still in the process to consolidate the additional documentation from our wiki into our site. Once done I will document the new feature coming with SLING-4330. Regards, O. > Thanks, > Radu > > [0] - https://issues.apache.org/jira/browse/SLING-4330 > [1] - https://sling.apache.org/documentation/bundles/scripting.html
