[ 
https://issues.apache.org/jira/browse/SLING-8798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-8798:
------------------------------------
    Attachment: SLING-8798.patch

> AclLine.getRestrictions should not return null
> ----------------------------------------------
>
>                 Key: SLING-8798
>                 URL: https://issues.apache.org/jira/browse/SLING-8798
>             Project: Sling
>          Issue Type: Improvement
>          Components: Repoinit
>            Reporter: Angela Schreiber
>            Priority: Major
>         Attachments: SLING-8798.patch
>
>
> while trying to add nullable/notnull annotations in _sling-jcr-repoinit_ to 
> improve overall readability and maintainability of the code base, i noticed 
> that {{AclLine.getRestrictions}} may return null. I would recommend to change 
> this to be consistent with {{AclLine.getProperty}}, which returns an empty 
> list in case no values exist for a given property name.
> Proposed patch attached (including replacing a private static final 
> EMPTY_LIST field by {{Collections.emptyList}}, which afaik is also defined to 
> be immutable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to