On Mon, 2019-11-11 at 14:49 +0100, Carsten Ziegeler wrote: > Am 11.11.2019 um 11:51 schrieb Robert Munteanu: > > On Fri, 2019-11-08 at 14:18 +0100, Carsten Ziegeler wrote: > > > Hi > > > > > > it seems you run with all available checks. You should only run > > > api > > > region checks if you use api regions. We recently moved all > > > analysers > > > that use api regions to the regions extension. > > > > As a bit of context, I started to incrementally use the feature > > model > > tooling on a simple project. I did so without any sort of explicit > > configuration, as: > > > > 1. I don't like configurations :-) > > 2. I think the tooling should work out-of-the-box with sensible > > values, > > and allow customisation if needed. > > > > Would it be an option to separate the 'default' scans from the > > additional scans, like the API order one? > > > The api regions should be optional as they are in a separate module. > Unfortunately, as the api-jars mojo uses extensions as well, this > separate module gets pulled in automatically. > > I absolutely agree that we should work with good ootb configurations. > > So maybe we should configure the slingfeature maven plugin with a > good > set of basic analysers. If someone wants additional checks, they can > be > configured. > > > > The other check is done by the analyser for OSGi connect; I can't > > > recall > > > why this check was useful though. > > > > Ack, would be interesting to know. Maybe this one would also be a > > candidate for the non-default set of scanners? If the check is > > related > > to [1], maybe it's not useful for everyone right now. > > > Agreed > > So in summary, we should configure a good default set of analysers > and > provide a way to add analysers (and skip the default ones)
Sound good to me. Filed a Jira issue so we don't forget about this: https://issues.apache.org/jira/browse/SLING-8839 Thanks, Robert
