[
https://issues.apache.org/jira/browse/SLING-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987743#comment-16987743
]
Ashish Chopra edited comment on SLING-8853 at 12/4/19 11:02 AM:
----------------------------------------------------------------
I've updated the PR for this issue [0] with the tests for ActiveResourceQueue
and its corresponding provider's updates.
While I [couldn't get the existing Pax Exam based tests to
run|https://issues.apache.org/jira/browse/SLING-8853?focusedCommentId=16982140&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16982140]
still, I chose to take a different approach and write the test using Mock
Sling and Mock Sling Oak test-tooling.
[~marett], would request you to provide feedback on [0] and merge if acceptable.
[0] https://github.com/apache/sling-org-apache-sling-distribution-core/pull/24
was (Author: ashishc):
I've updated the PR for this issue [0] with the tests for ActiveResourceQueue
and its corresponding provider's updates.
While I [couldn't get the existing Pax Exam based tests to
run|https://issues.apache.org/jira/browse/SLING-8853?focusedCommentId=16982140&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16982140]
still, I chose to take a different approach and write the test using Mock
Sling and Mock Sling Oak test-tooling.
[~marett], would request you to provide feedback on [0] and merge.
[0] https://github.com/apache/sling-org-apache-sling-distribution-core/pull/24
> Develop an Active variant of ResourceQueue and make it available as possible
> queue.provider for ForwardDistributionAgentFactory
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-8853
> URL: https://issues.apache.org/jira/browse/SLING-8853
> Project: Sling
> Issue Type: Improvement
> Components: Content Distribution
> Reporter: Ashish Chopra
> Assignee: Timothee Maret
> Priority: Major
> Fix For: Content Distribution Core 0.4.2
>
> Attachments:
> 0001-SLING-8853-Adds-ActiveResourceQueue-and-makes-it-ava.patch,
> 0003-SLING-8853-SLING-8854-enabling-ActiveResourceQueue-t.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Via SLING-7754, a [JCR Resource-backed
> queue|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/queue/impl/resource/ResourceQueue.java]
> [0] implementation was developed for usecases where a queue processor wasn't
> required, {{ResourceQueue}} implementation is currently {{PASSIVE}}.
> Given above, it is not possible to leverage {{ResourceQueue}} as a
> [{{queue.provider}} for {{DistributionAgents}} created via
> {{ForwardDistributionAgentFactory}}|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/deb3d2ae33c4f4678c8503091a9fffdbb141e569/src/main/java/org/apache/sling/distribution/agent/impl/ForwardDistributionAgentFactory.java#L171-L178]
> [1].
> This issue aims to add an "Active" variant of Resource backed queues and
> provide it as an option for {{ForwardDistributionAgentFactory}}.
> [0]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/queue/impl/resource/ResourceQueue.java
> [1]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/deb3d2ae33c4f4678c8503091a9fffdbb141e569/src/main/java/org/apache/sling/distribution/agent/impl/ForwardDistributionAgentFactory.java#L171-L178
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
