[
https://issues.apache.org/jira/browse/SLING-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988319#comment-16988319
]
Andreas Schaefer commented on SLING-8875:
-----------------------------------------
[~cziegeler] Sorry, I got confused between the "includeArtifact" property of
the aggregate-features goal and the actual "include-artifact" goal. I mistook
the class IncludeArtifact.java as the property class and overlooked that it is
a Mojo (maybe we should rename it to "IncludeArtifactMojo.java" to avoid
confusion).
I can merge the create-fm-descriptor into the include-artifact as they seem to
do the same thing even though I think the naming might be misleading but that
is fine if it is documented.
My code is based on the CP Converter code and I just took any code necessary to
make it work. I will go ahead and merge my code into the include-artifact mojo
and get ride of the unnecessary code.
In my code I was adding compile dependencies to the FM as they are not provided
by other FMs (otherwise they would not be in compile scope). That said there is
also the question if we want to allow the creator to add Repo-Init code
snippets to this FM. I have a project where my code needs to have a System User
created and set permissions on it.
> Create new Goal to create a FM Descriptor from a Maven Module
> -------------------------------------------------------------
>
> Key: SLING-8875
> URL: https://issues.apache.org/jira/browse/SLING-8875
> Project: Sling
> Issue Type: New Feature
> Components: Feature Model
> Affects Versions: slingfeature-maven-plugin 1.1.10
> Reporter: Andreas Schaefer
> Assignee: Andreas Schaefer
> Priority: Major
> Fix For: slingfeature-maven-plugin 1.1.12
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In order to use FM Descriptor in projects modules should be creating and
> exposing their FM Descriptors in local / remote Maven repositories. This way
> an assembler can take these FMs and build up its Sling instance.
> To avoid making each module to write their own FM Descriptor we should have a
> Goal in the SlingFeature Maven Plugin that does that automatically.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
