[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988627#comment-16988627
]
Timothee Maret edited comment on SLING-8869 at 12/5/19 10:12 AM:
-----------------------------------------------------------------
{quote}If such a mechanism exists, can you please explain it here for my better
understanding
{quote}
DistributionTransportSecretProvider is an API and anyone can provide an
implementation for it.
{quote}Can you please help me understand the benefit of a failing HTTP call as
you propose?
{quote}
It covers both _dynamic_ and _static_ secret providers without making any
assumption about the providers being _dynamic_ or _static_.
was (Author: marett):
{quote}If such a mechanism exists, can you please explain it here for my better
understanding
{quote}
DistributionTransportSecretProvider is an API and anyone can provide an
implementation for it.
{quote}Can you please help me understand the benefit of a failing HTTP call as
you propose?
{quote}
It covers both _dynamic_ and _static_ secret providers.
> SimpleHttpDistributionTransport does not refresh the secret for token based
> implementations.
> --------------------------------------------------------------------------------------------
>
> Key: SLING-8869
> URL: https://issues.apache.org/jira/browse/SLING-8869
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
> Reporter: Mohit Arora
> Assignee: Timothee Maret
> Priority: Critical
> Fix For: Content Distribution Core 0.4.2
>
> Attachments: SLING-8869-new.patch, SLING-8869.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> While saving the {{contextKeyExecutor}} in {{DistributionTransportContext}}
> map, it is not expected that the secret associated with the executor could be
> expired. This can happen in case of access token based implementations where
> the token is expired after a certain period of time and has to be refreshed.
> The code to refresh the token is written in the secret provider but since the
> executor is [cached in the
> map|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/transport/impl/SimpleHttpDistributionTransport.java#L208]
> the secrets are not refreshed. It works fine for credentials based secret
> provider but not for access token based.
> cc - [~marett]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
