tmaret commented on a change in pull request #27: SLING-8868 DistributionPackage built using … URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/27#discussion_r354324643
########## File path: src/main/java/org/apache/sling/distribution/packaging/impl/DistributionPackageUtils.java ########## @@ -20,6 +20,7 @@ import org.apache.commons.io.FileUtils; import org.apache.commons.io.IOUtils; +import org.apache.jackrabbit.JcrConstants; Review comment: @actinium15 do we require this jackrabbit dependency ? It seems we could avoid it by referencing constants on the `javax.jcr.Node` and `javax.jcr.Property` interfaces. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
