[
https://issues.apache.org/jira/browse/SLING-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991726#comment-16991726
]
Robert Munteanu edited comment on SLING-8905 at 12/9/19 3:59 PM:
-----------------------------------------------------------------
[~cziegeler]
1) We can either fail or use both. At the moment I would be inclined to say we
should fail, since I don't yet see a case where we want to use both the scm-tag
and source-ids
2) maybe we should change the scm corrdinates to be a list of objects, e.g.
{code}
"scm": {
[
"source": "scm:git...",
"tag": "foo-1.0"
],
[
"source": "scm:svn...",
"tag": "bar-1.1"
]
}
{code}
Then we could support multiple SCM locations without ambiguity.
_Edit_: that being said, I don't think we need multiple scm locations _now_,
although the possibility exists.
was (Author: rombert):
[~cziegeler]
1) We can either fail or use both. At the moment I would be inclined to say we
should fail, since I don't yet see a case where we want to use both the scm-tag
and source-ids
2) maybe we should change the scm corrdinates to be a list of objects, e.g.
{code}
"scm": {
[
"source": "scm:git...",
"tag": "foo-1.0"
],
[
"source": "scm:svn...",
"tag": "bar-1.1"
]
}
{code}
Then we could support multiple SCM locations without ambiguity.
> Always use scm-location if defined
> ----------------------------------
>
> Key: SLING-8905
> URL: https://issues.apache.org/jira/browse/SLING-8905
> Project: Sling
> Issue Type: Improvement
> Components: Maven Plugins and Archetypes
> Reporter: Robert Munteanu
> Priority: Major
> Fix For: slingfeature-maven-plugin 1.1.12
>
>
> The behaviour of {{scm-location}} and {{source-ids}} is not consistent. The
> {{sourceId}} is always consulted, while the {{scm-location}} is used only if
> the regular sources checkout fails.
> This does not help when, for instance, an artifact A wraps artifact B and
> also provides a {{-sources}} jar. The {{ApisJarMojo}} will download the
> {{-sources}} jar and ignore the {{scm-location}} information, leading to
> sources not being found.
> I think that {{scm-location}} should always be used preferred to automatic
> download os the {{-sources}} jar, as it is effectively an override.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
