yuansc commented on a change in pull request #1: [SLING-8246]Fix server side
test hang with repeat "Waiting for the following bund…
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/1#discussion_r361085696
##########
File path: pom.xml
##########
@@ -120,6 +121,34 @@
</profiles>
<dependencies>
+ <!--
Review comment:
@kwin - Sling JUnit Core uses <Embed-Packages/> to embed a few JUnit jars
into the bundle. Sling parent 35 has drop the support for maven-bundle-plugin.
We may need to stick with 34 until there a bnd.bnd that can simulate
<Embed-Packages/> Felix Maven bundle plugin with in bnd-maven-plugin for Sling
JUnit Core.
Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
