kwin commented on a change in pull request #1: [SLING-8246]Fix server side test
hang with repeat "Waiting for the following bund…
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/1#discussion_r363089600
##########
File path: src/main/java/org/apache/sling/junit/impl/AnnotationsProcessor.java
##########
@@ -18,23 +18,30 @@
import java.lang.reflect.Field;
-import org.apache.felix.scr.annotations.Component;
-import org.apache.felix.scr.annotations.Service;
import org.apache.sling.junit.TestObjectProcessor;
import org.apache.sling.junit.annotations.TestReference;
import org.osgi.framework.BundleContext;
import org.osgi.framework.ServiceReference;
+import org.osgi.service.component.annotations.Activate;
+import org.osgi.service.component.annotations.Component;
+import org.osgi.service.component.annotations.Deactivate;
+import org.osgi.service.component.annotations.Modified;
import org.osgi.service.component.ComponentContext;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/** Processor for annotations in test classes */
-@Component(immediate=true)
-@Service
+@SuppressWarnings("deprecation")
+@Component(
+ service = TestObjectProcessor.class,
+ immediate = true
+)
public class AnnotationsProcessor implements TestObjectProcessor {
private Logger log = LoggerFactory.getLogger(getClass());
private BundleContext bundleContext;
+ @Activate
+ @Modified
Review comment:
Modified annotation changes the semantics, just use `@Activate`!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
