kwin commented on a change in pull request #1: [SLING-8246]Fix server side test
hang with repeat "Waiting for the following bund…
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/1#discussion_r363089983
##########
File path:
src/main/java/org/apache/sling/junit/impl/servlet/TestLogServlet.java
##########
@@ -57,11 +61,53 @@
import ch.qos.logback.core.Layout;
import ch.qos.logback.core.read.CyclicBufferAppender;
-@Component(immediate=true, metatype=true,
- label = "Apache Sling Test Log Collector",
- description = "Servlet that exposes logs collected for a particular
test execution"
+@Component(
+ service = Servlet.class,
+ immediate = true,
+ configurationPolicy = ConfigurationPolicy.OPTIONAL,
+ property = {
Review comment:
no need for that as you use property configuration type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
