[ 
https://issues.apache.org/jira/browse/SLING-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17011470#comment-17011470
 ] 

Carsten Ziegeler commented on SLING-8975:
-----------------------------------------

This is a change in the contract and I would assume that if a resource returns 
null for the resource type, a lot of code will just blow up. The javadoc of the 
method does not mention null as a possible return value.
I think a resource must have a resource type

> Sling API: Resource.getResourceType should be @Nullable
> -------------------------------------------------------
>
>                 Key: SLING-8975
>                 URL: https://issues.apache.org/jira/browse/SLING-8975
>             Project: Sling
>          Issue Type: Improvement
>          Components: API
>    Affects Versions: API 2.21.0
>            Reporter: Stefan Seifert
>            Assignee: Stefan Seifert
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> currently, the {{getResourceType()}} method of the {{Resource}} interface is 
> marked as {{@NotNull}} in the API.
> imho this is wrong:
> * it is not mandatory that every resource has a resource type
> * the JCR resource provider uses the JCR primary type as "fallback" value 
> when no resource type is defined as property, but this is not necessary the 
> case for other resource providers or synthetic resources



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to