DominikSuess commented on a change in pull request #23: SLING-8973 - fixing
runmode handling for repoinit configuration handling
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/23#discussion_r364583305
##########
File path:
src/main/java/org/apache/sling/feature/cpconverter/acl/DefaultAclManager.java
##########
@@ -134,7 +134,7 @@ public void
addRepoinitExtension(List<VaultPackageAssembler> packageAssemblers,
String text = formatter.toString();
if (!text.isEmpty()) {
- featureManager.addOrAppendRepoInitExtension(text);
+ featureManager.addOrAppendRepoInitExtension(text, null);
Review comment:
I was thinking about that but tbh it makes it easier to miss that you might
need to pass a runmode (what made me miss the need to pass it earlier). if you
still insist I certainly can add a corresopnding alternative wrapping signature
and replace the null calls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
