[ 
https://issues.apache.org/jira/browse/SLING-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013407#comment-17013407
 ] 

Oliver Lietz commented on SLING-8936:
-------------------------------------

[~bdelacretaz], Try to avoid hacks like {{waitForSling()}} and use service 
dependencies instead, see 
[FreemarkerTestSupport|https://github.com/apache/sling-org-apache-sling-scripting-freemarker/blob/master/src/test/java/org/apache/sling/scripting/freemarker/it/tests/FreemarkerTestSupport.java]
 and 
[SimpleIT|https://github.com/apache/sling-org-apache-sling-scripting-freemarker/blob/master/src/test/java/org/apache/sling/scripting/freemarker/it/tests/SimpleIT.java]
 for example. The tests (external calls via HTTP) are only executed when Sling 
is ready to serve requests.

> Improve test coverage for path-mounted servlets
> -----------------------------------------------
>
>                 Key: SLING-8936
>                 URL: https://issues.apache.org/jira/browse/SLING-8936
>             Project: Sling
>          Issue Type: Improvement
>          Components: Servlets
>    Affects Versions: Servlets Resolver 2.5.8
>            Reporter: Bertrand Delacretaz
>            Assignee: Bertrand Delacretaz
>            Priority: Minor
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> The code that I need to modify for SLING-8110 is not covered by this module's 
> tests, I need to improve test coverage before making those changes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to