yuansc commented on a change in pull request #1: [SLING-8246]Fix server side 
test hang with repeat "Waiting for the following bund…
URL: 
https://github.com/apache/sling-org-apache-sling-junit-core/pull/1#discussion_r365629182
 
 

 ##########
 File path: 
src/main/java/org/apache/sling/junit/impl/servlet/TestLogServlet.java
 ##########
 @@ -98,18 +127,20 @@
 
     private Layout<ILoggingEvent> layout;
 
+    @SuppressWarnings("rawtypes")
     private ServiceRegistration filter;
 
     private volatile Description currentTest;
 
     private final Object appenderLock = new Object();
 
     @Activate
-    protected void activate(BundleContext ctx, Map<String, ?> config) throws 
Exception {
-        registerServlet(config);
-        registerAppender(config);
+    @Modified
+    protected void activate(BundleContext ctx, Config cfg) throws Exception {
 
 Review comment:
   The use of @Modfied has been fixed.   Not removing ctx for it is used by 
registerFilter(ctx);
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to