[
https://issues.apache.org/jira/browse/SLING-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014969#comment-17014969
]
Bertrand Delacretaz edited comment on SLING-8936 at 1/14/20 12:06 PM:
----------------------------------------------------------------------
Thank you [~olli] for your comments - I haven't found a reliable set of
services to wait for to avoid the {{waitForSling()}} method so I'll leave it in
for now, it's not elegant but works reliably. The module uses an older
{{o.a.s.engine}} dependency which I don't want to change just for the tests and
that complicates this a bit.
The ITs are now ready but I'll leave this ticket open as there are two SNAPSHOT
dependencies to remove once the {{sling.api}} and {{scripting.core}} modules
are released: in {{pom.xml}} and in {{ServletResolverTestSupport.java}}.
was (Author: bdelacretaz):
Thank you [~olli] for your comments - I haven't found a reliable set of
services to wait for to avoid the {{waitForSling()}} method so I'll leave it in
for now, it's not elegant but works reliably. The module uses an older
{{o.a.s.engine}} dependency which I don't want to change just for the tests and
that complicates this a bit.
The ITs are now ready but I'll leave this ticket open as there are two SNAPSHOT
dependencies to remove once the {{sling.api}} and {{scripting.core}} modules
are released.
> Improve test coverage for path-mounted servlets
> -----------------------------------------------
>
> Key: SLING-8936
> URL: https://issues.apache.org/jira/browse/SLING-8936
> Project: Sling
> Issue Type: Improvement
> Components: Servlets
> Affects Versions: Servlets Resolver 2.5.8
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Minor
> Fix For: Servlets Resolver 2.5.10
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The code that I need to modify for SLING-8110 is not covered by this module's
> tests, I need to improve test coverage before making those changes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
