rombert commented on issue #13: SLING-9045 - Rebase of PR #1 - Adding option to disable URL params check URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/13#issuecomment-582642037 Thanks for picking this up @jfmitchell ! Some notes: # the build fails ( see Jenkins check ) - `[ERROR] org.apache.sling.dynamicinclude: Version increase required; detected 4.2.1, suggested 4.3.0` # the branch cannot be rebased due to conflicts; please squash all commits into one and then rebase # you can credit the original author, for instance by using `Originally-By: <email>` in the commit message Otherwise changes LGTM.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
