kwin commented on a change in pull request #27: SLING-9066 - separating
collecting of affected entries from updating …
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/27#discussion_r378271839
##########
File path:
src/main/java/org/apache/sling/feature/cpconverter/vltpkg/VaultPackageAssembler.java
##########
@@ -198,14 +200,18 @@ public File getEntry(String path) {
}
public void updateDependencies(Map<PackageId, Set<Dependency>>
mutableContentsIds) {
+ Map<Dependency, Set<Dependency>> matches = new HashMap<>();
for (Dependency dependency : dependencies) {
Review comment:
why not using
https://docs.oracle.com/javase/8/docs/api/java/util/Iterator.html#remove--
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
