Hi,
The API PR attracted a -1 which I understand and respect.

I cant see of a way or revolving the -1 without making the API
unsupportable long term, hence I have closed the PRs and closed SLING-9060
as a Wont fix and will look for alternative ways of solving the problem.
Best Regards
Ian

On Mon, 10 Feb 2020 at 16:28, Ian Boston <i...@tfd.co.uk> wrote:

> > Let me know whether that is enough or it needs expansions.
>
> +1, works.
>
> Interestingly it did need all occurrences of bundles pointing to SNAPSHOT
> Sling API bundles to be updated, and for those bundles to depend on the
> latest snapshot of the API. scripting.core and servlets.resolver had to be
> fixed before the tests would pass.
>
> Thanks for the comments on the PRs. I have tried to address them with more
> commits.
> Best Regards
> Ian
>
> On Sat, 8 Feb 2020 at 12:18, Robert Munteanu <romb...@apache.org> wrote:
>
>> Hi Ian,
>>
>> On Sat, 2020-02-08 at 09:48 +0000, Ian Boston wrote:
>> > Hi,
>> > The PRs have been opened, see the issue.
>> > I will do complete implementations to verify it works as required in
>> > AEM.
>> > I would also like to insure no disruption to Sling, and since it's
>> > been a
>> > long time since I did this, how do run full CI/CD and integrate a new
>> > API
>> > in Sling ? (a pointer would be great).
>> >
>>
>> I have added some instructions at
>>
>>   https://sling.apache.org/contributing.html#testing
>>
>> Let me know whether that is enough or it needs expansions.
>>
>> Thanks,
>> Robert
>>
>> > Best Regards
>> > Ian
>> >
>> >
>> > On Sat, 8 Feb 2020 at 09:23, Ian Boston <i...@tfd.co.uk> wrote:
>> >
>> > > Hi,
>> > > Opened [1] to track the work.
>> > > Best Regards
>> > > Ian
>> > >
>> > > 1 https://issues.apache.org/jira/browse/SLING-9060
>> > >
>> > > On Wed, 5 Feb 2020 at 22:12, Ian Boston <i...@tfd.co.uk> wrote:
>> > >
>> > > > Hi,
>> > > > Ok.
>> > > >
>> > > > o.a.s.api.redirect for the API, and a patch to the Get servlet to
>> > > > use the
>> > > > API.
>> > > > Will do PRs shortly.
>> > > >
>> > > > Best Regards
>> > > > Ian
>> > > >
>> > > >
>> > > > On Tue, 4 Feb 2020 at 14:13, Bertrand Delacretaz <
>> > > > bdelacre...@apache.org>
>> > > > wrote:
>> > > >
>> > > > > On Tue, Feb 4, 2020 at 1:58 PM Ian Boston <i...@tfd.co.uk>
>> > > > > wrote:
>> > > > > > ...New package, agreed, no ripples.
>> > > > > > o.a.s.api.response ? ...
>> > > > >
>> > > > > o.a.s.api.redirect is more specific and I think having packages
>> > > > > with
>> > > > > few interfaces is fine?
>> > > > >
>> > > > > The existing api.auth and api.security packages for example
>> > > > > only have
>> > > > > 3 items each.
>> > > > >
>> > > > > It has the benefit of OSGi package versioning being very
>> > > > > specific.
>> > > > >
>> > > > > -Bertrand
>> > > > >
>>
>>

Reply via email to