[
https://issues.apache.org/jira/browse/SLING-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038186#comment-17038186
]
Sonal Gupta edited comment on SLING-8946 at 2/17/20 9:33 AM:
-------------------------------------------------------------
[~diru] I have added a performance test case in
[https://github.com/sonagupt/sling-org-apache-sling-resourceresolver/blob/master/src/test/java/org/apache/sling/resourceresolver/impl/providers/ResourceProviderTrackerTest.java#L363]
mvn clean verify
-Dtest=org.apache.sling.resourceresolver.impl.providers.ResourceProviderTrackerTest.java#testPerformance
Can you please try and execute this with and without your changes. As per my
observation the total time taken for creating and registering 1000 resources
earlier was only ~300 ms which has increased a lot after this change to
~6000+ms which is ~200% increase. This has impacted performance a lot. Can you
please suggest on the same.
was (Author: sonagupt):
[~diru] I have added a performance test case in
[https://github.com/sonagupt/sling-org-apache-sling-resourceresolver/blob/master/src/test/java/org/apache/sling/resourceresolver/impl/providers/ResourceProviderTrackerTest.java#L363]
mvn clean verify
-Dtest=org.apache.sling.resourceresolver.impl.providers.ResourceProviderTrackerTest.java#testPerformance
Can you please try and execute this with and without your changes. As per my
observation the total time taken for creating and registering 1000 resources
earlier was only ~300 ms which has increased a lot after this change to
~8000+ms which is 300% increase. This has impacted performance a lot. Can you
please suggest on the same.
> Non-deterministic shadowing of resource observation
> ---------------------------------------------------
>
> Key: SLING-8946
> URL: https://issues.apache.org/jira/browse/SLING-8946
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
> Affects Versions: Resource Resolver 1.5.34
> Reporter: Dirk Rudolph
> Assignee: Robert Munteanu
> Priority: Critical
> Fix For: Resource Resolver 1.6.18
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The BasicObservationReporter implements shadowing of events being propagated
> per ResourceProvider instance [1]. Assuming we do have 2 ResourceProviders
> registered, where the one shadows the other like this:
> - RP A registered on /
> - RP B registered on /path
> then currently the excludes given to the BasicObservationReporter are
> different depending on either RP A or RP B gets registered first:
> - RP A before RP B => excludes are empty
> - RP B before RP A => excludes contain /path
> This is because only the newly registered RP gets its ProviderContext updated
> [2]
> Same applies if RP B is registered before RP A and gets unregistered. In that
> case the ObservationReporter of RP A stays untouched.
> [1]
> [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/observation/BasicObservationReporter.java#L102]
> [2]
> [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/providers/ResourceProviderTracker.java#L358]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
