YegorKozlov opened a new pull request #15: use Set instead of a List to test  
   In our setup we have a list of ignored GET parameters 
(_include-filter.config.ignoreUrlParams_) which grew with time to a hundred or 
so elements . loads these into a 
_java.util.List_ which is further  checked from IncludeTagFilter via 
   Calling _List#contains_ in a loop is kind of a smell.  I believe 
_java.util.Set_ will be a more appropriate containter with fixed O(1) cost of 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to