[
https://issues.apache.org/jira/browse/SLING-9247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yegor Kozlov updated SLING-9247:
--------------------------------
External issue URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/15
> Improve Performance Of Testing Ignored GET Parameters
> -----------------------------------------------------
>
> Key: SLING-9247
> URL: https://issues.apache.org/jira/browse/SLING-9247
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: Dynamic Include 3.1.6
> Reporter: Yegor Kozlov
> Priority: Minor
> Fix For: Dynamic Include 3.2.0
>
>
> This is a follow-up on SLING-9045
> _org.apache.sling.dynamicinclude.Configuration_ loads the list of ignored GET
> parameters into a _java.util.List_ which is further checked from
> _IncludeTagFilter_ via _List#contains_
> Calling _List#contains_ in a loop is kind of a smell. I believe
> _java.util.Set_ will be a more appropriate container with fixed O(1) cost of
> _contains()_.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
