[
https://issues.apache.org/jira/browse/SLING-9171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065932#comment-17065932
]
Bertrand Delacretaz commented on SLING-9171:
--------------------------------------------
Naming is hard...thank you [~jsedding], Nitin has made his contribution with
set/default, I hope that works for you.
[~nitigupt] I have merged your parser PR, thank you very much! And made a few
changes in the commits that follow it at
https://github.com/apache/sling-org-apache-sling-repoinit-parser/ , in
particular I moved the dates, types and values parsing logic to the
{{PropertyLine}} class, I think it's easier to debug there than in the grammar
itself. Sorry for hinting at the opposite structure earlier, but looking at it
the grammar was becoming too complex for my taste.
I also fixed an inconsistency in the quoted strings, the start/end quotes were
not removed for the general case.
Note that {{PropertyLine}} now returns a list of {{Object}} with specific types
based on their set/default statements, you'll need to modify the JCR pull
request for this but I think it's more consistent in this way.
Can you review my changes and see if they work for you?
> Support for settings properties on paths created via repoinit create path
> -------------------------------------------------------------------------
>
> Key: SLING-9171
> URL: https://issues.apache.org/jira/browse/SLING-9171
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
> Reporter: Nitin Gupta
> Assignee: Bertrand Delacretaz
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Apart from jcr:primaryType and mixin, there is a requirement to add custom
> properties to the nodes valuemap via repoinit. This is a gap currently.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
