Done with
https://github.com/apache/sling-org-apache-sling-launchpad-test-bundles/commit/43956dd07234ddc3263ce29c5b7c3f7198ad4caf.
That leaves us with 2 remaining issues:
[ERROR] Failures:
[ERROR]
WarSelectorServletTest.testSelectorOne:23->ResolutionTestBase.assertServlet:75
Content contains servlet.class.name property (** Resource dumped by
PlainTextRenderer**
Resource path:/servlet-resolution-tests/1585747495298/this_is_a_test_node_
Resource metadata: {sling.modificationTime=-1, sling.characterEncoding=null,
sling.parameterMap={}, sling.contentType=null, sling.creationTime=-1,
sling.contentLength=-1,
sling.resolutionPath=/servlet-resolution-tests/1585747495298/this_is_a_test_node_,
sling.resolutionPathInfo=.WAR_TEST_SEL_1.txt}
Resource type: nt:unstructured
Resource super type: -
** Resource properties **
jcr:primaryType: nt:unstructured
text: This is a test node 1585747503024
)
[ERROR]
WarSelectorServletTest.testSelectorTwo:29->ResolutionTestBase.assertServlet:75
Content contains servlet.class.name property (** Resource dumped by
PlainTextRenderer**
Resource path:/servlet-resolution-tests/1585747495298/this_is_a_test_node_
Resource metadata: {sling.modificationTime=-1, sling.characterEncoding=null,
sling.parameterMap={}, sling.contentType=null, sling.creationTime=-1,
sling.contentLength=-1,
sling.resolutionPath=/servlet-resolution-tests/1585747495298/this_is_a_test_node_,
sling.resolutionPathInfo=.WAR_TEST_SEL_2.txt}
Resource type: nt:unstructured
Resource super type: -
** Resource properties **
jcr:primaryType: nt:unstructured
text: This is a test node 1585747503113
)
> On 1. Apr 2020, at 15:25, Robert Munteanu <[email protected]> wrote:
>
> On Wed, 2020-04-01 at 15:02 +0200, Konrad Windszus wrote:
>> Hi,
>> does anything speak against moving the ITs from
>> https://github.com/apache/sling-org-apache-sling-launchpad-testing <
>> https://github.com/apache/sling-org-apache-sling-launchpad-testing>
>> into https://github.com/apache/sling-org-apache-sling-starter? <
>> https://github.com/apache/sling-org-apache-sling-starter?>
>> That way the ITs cannot be missed when updating the starter.
>> Was there any particular reason, why this hasn't been done in the
>> past?
>
> In general that sounds like a good idea to me. I even started working
> on unifying all testing modules, see [1].
>
> I ran out of time though, and Oli had some concerns due to consuming
> the artifacts in the Karaf features, see the jira issue for details.
>
> Robert
>
> [1]: https://issues.apache.org/jira/browse/SLING-7935
>
