[
https://issues.apache.org/jira/browse/SLING-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-9351:
-----------------------------------
Description:
With SLING-8680 we seem to have found a interesting scenario in our testing
setup:
- org.apache.sling.launchpad.test-services-war is packaged as a WAR file with
a manifest, exposing two Servlets
- before SLING-8680 we only checked for a manifest when transforming
resources, now we reject the WAR file
- we have two tests that validate that those servlets are running properly -
see [WarSelectorServletTest.java
(permalink)|https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/blob/49e5c948a0115566f778a5696e7f3df45e5dd3f5/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/servlets/resolution/WarSelectorServletTest.java]
IMO we should not test or support this scenario (WAR files installed as OSGi
bundles) as it's a quite convoluted and specific scenario.
Therefore I propose that we retire this module following our [Deprecated Sling
Modules
process|https://sling.apache.org/documentation/development/deprecating-sling-modules.html]
and delete the two tests.
was:
With SLING-8660 we seem to have found a interesting scenario in our testing
setup:
- org.apache.sling.launchpad.test-services-war is packaged as a WAR file with
a manifest, exposing two Servlets
- before SLING-8660 we only checked for a manifest when transforming
resources, now we reject the WAR file
- we have two tests that validate that those servlets are running properly -
see [WarSelectorServletTest.java
(permalink)|https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/blob/49e5c948a0115566f778a5696e7f3df45e5dd3f5/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/servlets/resolution/WarSelectorServletTest.java]
IMO we should not test or support this scenario (WAR files installed as OSGi
bundles) as it's a quite convoluted and specific scenario.
Therefore I propose that we retire this module following our [Deprecated Sling
Modules
process|https://sling.apache.org/documentation/development/deprecating-sling-modules.html]
and delete the two tests.
> Deprecate org.apache.launchpad.test-services-war
> ------------------------------------------------
>
> Key: SLING-9351
> URL: https://issues.apache.org/jira/browse/SLING-9351
> Project: Sling
> Issue Type: Task
> Components: Launchpad, Testing
> Reporter: Robert Munteanu
> Assignee: Robert Munteanu
> Priority: Major
> Fix For: Starter 12
>
>
> With SLING-8680 we seem to have found a interesting scenario in our testing
> setup:
> - org.apache.sling.launchpad.test-services-war is packaged as a WAR file
> with a manifest, exposing two Servlets
> - before SLING-8680 we only checked for a manifest when transforming
> resources, now we reject the WAR file
> - we have two tests that validate that those servlets are running properly -
> see [WarSelectorServletTest.java
> (permalink)|https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/blob/49e5c948a0115566f778a5696e7f3df45e5dd3f5/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/servlets/resolution/WarSelectorServletTest.java]
> IMO we should not test or support this scenario (WAR files installed as OSGi
> bundles) as it's a quite convoluted and specific scenario.
> Therefore I propose that we retire this module following our [Deprecated
> Sling Modules
> process|https://sling.apache.org/documentation/development/deprecating-sling-modules.html]
> and delete the two tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
