On Thursday, April 9, 2020 6:15:16 PM CEST Robert Munteanu wrote: > Hi, Hi,
> With SLING-8680 [1] we seem to have found a interesting scenario in our > testing setup: > > - org.apache.sling.launchpad.test-services-war [2] is packaged as a WAR > file with a manifest, exposing two Servlets > - before SLING-8680 [1] we only checked for a manifest when > transforming resources, now we reject the WAR file > - we have two tests that validate that those servlets are running > properly - see WarSelectorServletTest.java [3] > > IMO we should not test or support this scenario (WAR files installed as > OSGi bundles) as it's a quite convoluted and specific scenario. > > Therefore I propose that we retire this module following our Deprecated > Sling Modules process and delete the two tests. > > Please vote to accept this retirement. This majority vote is open for > at least 72 hours. +1 to deprecate test-services-war and testing-war O. > Thanks, > Robert > > [1]: https://issues.apache.org/jira/browse/SLING-8680 > [2]: > https://github.com/apache/sling-org-apache-sling-launchpad-test-services-wa > r/blob/e93ea20c1f62d8219efd0e749c7e12f4225695d2/pom.xml [3]: > https://github.com/apache/sling-org-apache-sling-launchpad-integration-test > s/blob/49e5c948a0115566f778a5696e7f3df45e5dd3f5/src/main/java/org/apache/sli > ng/launchpad/webapp/integrationtest/servlets/resolution/WarSelectorServletTe > st.java
