[
https://issues.apache.org/jira/browse/SLING-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085766#comment-17085766
]
Konrad Windszus edited comment on SLING-9378 at 4/17/20, 5:39 PM:
------------------------------------------------------------------
Ah, sorry, you caught me. Indeed I clarified this in
https://github.com/apache/sling-site/commit/11928cf594128c2a823bae774cb06055d1db6c7c.
Previously the documentation only talked about path! Similarly for
https://github.com/apache/sling-org-apache-sling-servlets-annotations/blob/9b7132ca1a9b033495f537019a858bddc4afd1b4/src/main/java/org/apache/sling/servlets/annotations/SlingServletFilter.java#L52
(only generic path was mentioned). However, we changed the behaviour with
SLING-7759. I would tend to restore the {{sling.filter.pattern}} behaviour
before (i.e. match against request path) and introduce a new property for
matching against the resolved path.
On the other hand nowadays
https://osgi.org/specification/osgi.cmpn/7.0.0/service.http.whiteboard.html#d0e121055
could be used for filters against request paths!
was (Author: kwin):
Ah, sorry, you caught me. Indeed I clarified this in
https://github.com/apache/sling-site/commit/11928cf594128c2a823bae774cb06055d1db6c7c.
Previously the documentation only talked about path! Similarly for
https://github.com/apache/sling-org-apache-sling-servlets-annotations/blob/9b7132ca1a9b033495f537019a858bddc4afd1b4/src/main/java/org/apache/sling/servlets/annotations/SlingServletFilter.java#L52
(only generic path was mentioned). However, we changed the behaviour with
SLING-7759. I would tend to restore the {{sling.filter.pattern}} behaviour
before (i.e. match against request path) and introduce a new property for
matching against the resolved path.
> When internalRedirect and sling:match maps are added, filterPattern doesn't
> work
> --------------------------------------------------------------------------------
>
> Key: SLING-9378
> URL: https://issues.apache.org/jira/browse/SLING-9378
> Project: Sling
> Issue Type: Bug
> Affects Versions: Engine 2.6.16, Engine 2.6.18
> Reporter: Ankita Agarwal
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> ***sling.filter.pattern=/abcd/.** doesn't work after a map is added withÂ
> internalRedirect and sling:match. This is a issue due to
> [SLING-7759|https://issues.apache.org/jira/browse/SLING-7759]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
