[ 
https://issues.apache.org/jira/browse/SLING-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086416#comment-17086416
 ] 

Carsten Ziegeler commented on SLING-9378:
-----------------------------------------

Ok I think we have four options:
a) change it back to request path - and probably provide a new property for 
resource path - while this restores the old behaviour, this might break users 
relying on the current behaviour; the implementation is out for nearly two 
years.
b) leave it as is and provide a new property for request path
c) check against both - as the provided PR implements; this way it works for 
users pre SLING-7759 but also for new users relying on the changed behaviour
d) check against both (with PR), and provide two new properties, one clearly 
for resource path and one clearly for request path.

We broke users with SLING-7759, if we now go with a), we might break them a 
second time - and we might break new users; so I think we should not go with a) 
b) breaks users re SLING-7759 but keeps the behaviour for newer users
c) avoids breaking anyone, but does not allow to have different behaviour with 
different mappings
d) avoids breaking anyone but also provides enough flexibility

I'm leaning towards either c) or d)

> When internalRedirect and sling:match maps are added, filterPattern doesn't 
> work
> --------------------------------------------------------------------------------
>
>                 Key: SLING-9378
>                 URL: https://issues.apache.org/jira/browse/SLING-9378
>             Project: Sling
>          Issue Type: Bug
>    Affects Versions: Engine 2.6.16, Engine 2.6.18
>            Reporter: Ankita Agarwal
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> ***sling.filter.pattern=/abcd/.** doesn't work after a map is added with 
> internalRedirect and sling:match. This is a issue due to 
> [SLING-7759|https://issues.apache.org/jira/browse/SLING-7759]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to