mohiaror commented on a change in pull request #40:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/40#discussion_r413650429
##########
File path:
src/main/java/org/apache/sling/distribution/agent/impl/PrivilegeDistributionRequestAuthorizationStrategy.java
##########
@@ -37,12 +39,18 @@
private final String jcrPrivilege;
- public PrivilegeDistributionRequestAuthorizationStrategy(String
jcrPrivilege) {
+ private String[] additionalJcrPrivilegesForAdd;
+
+ private String[] additionalJcrPrivilegesForDelete;
Review comment:
@actinium15 I change the
additionalJcrPrivilegesForDelete/additionalJcrPrivilegesForAdd arrays based on
their nullability so can't use final here. Since they are used just once in the
class, I do not see a point in using a separate variable for keeping up with
the default value of these arrays.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
