rombert commented on pull request #51: URL: https://github.com/apache/sling-whiteboard/pull/51#issuecomment-618977267
Thanks a lot @cmrockwell . I see that the `LICENSE` file is there, so that is good. I am not sure if we need a `NOTICE` file though. I am trying to go through https://www.apache.org/dev/licensing-howto.html#alv2-dep , especially the section titled _Bundling an Apache-2.0-licensed dependency_. From an ASF point of view it does not seem that we need to change the NOTICE file, since the third party repository does not have a NOTICE file itself. A notice file should be generated automatically with the build ( but the build fails out-of-the-box for me). BTW, the possible names for the notice are `NOTICE` (preferred) and `NOTICE.txt`. The remaining question is how and if we need to add attribution to the source code files. Maybe @bdelacretaz or @cziegeler have an idea? Bertrand, Carsten - @cmrockwell has based some of his submission on code from https://bitbucket.org/srasmusson/webprofile-ref-project-v3, which is Apache-2.0 licensed. The changes are currently listed in https://github.com/apache/sling-whiteboard/blob/8386886dbe241020e11ae8c75ca487a204fe0bbf/saml-handler/NOTICE.md ( although I consider we don't need anything in the NOTICE file, see above ). How would you recommend that we record this attribution? --- @cmrockwell - once clarified I think we can merge this and then iterate. I suggest that we can keep a record of open items. This can be a simple TODO file in the repository root, a Jira task titled 'SAML authentication handler initial contribution', or anything else really. What would you prefer? Finally, I have not found an ICLA on file for you, I would encourage you to file on ( see https://www.apache.org/licenses/contributor-agreements.html ) as you seem to be on track for continued contributions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
