actinium15 commented on a change in pull request #40:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/40#discussion_r415343066
##########
File path:
src/test/java/org/apache/sling/distribution/agent/impl/PrivilegeDistributionRequestAuthorizationStrategyTest.java
##########
@@ -131,23 +175,53 @@ public void testNoPermissionOnDelete() throws Exception {
}
@Test
- public void testPermissionOnDelete() throws Exception {
+ public void testDefaultPermissionOnDelete() throws Exception {
String jcrPrivilege = "somePermission";
- PrivilegeDistributionRequestAuthorizationStrategy strategy = new
PrivilegeDistributionRequestAuthorizationStrategy(jcrPrivilege);
+ String DEFAULT_DELETE_PRIVELEGE = "jcr:removeNode";
Review comment:
Do we really need this? Can't we just use Privilege.JCR_REMOVE_NODE?
If we can't, please fix the typo (misspelt "privilege")
##########
File path:
src/test/java/org/apache/sling/distribution/agent/impl/PrivilegeDistributionRequestAuthorizationStrategyTest.java
##########
@@ -81,17 +95,19 @@ public void testNoPermissionOnAdd() throws Exception {
}
@Test
- public void testPermissionOnAdd() throws Exception {
+ public void testDefaultPermissionOnAdd() throws Exception {
String jcrPrivilege = "somePermission";
- PrivilegeDistributionRequestAuthorizationStrategy strategy = new
PrivilegeDistributionRequestAuthorizationStrategy(jcrPrivilege);
+ String DEFAULT_READ_PRIVELEGE = "jcr:read";
Review comment:
Do we really need this? Can't we just use Privilege.JCR_READ?
If we can't, please fix the typo (misspelt "privilege")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
