rombert commented on a change in pull request #1:
URL:
https://github.com/apache/sling-apache-sling-jar-resource-bundle/pull/1#discussion_r422000899
##########
File path: src/main/resources/META-INF/NOTICE.vm
##########
@@ -18,14 +18,19 @@
##
#if ($projectName)$projectName#else${project.name}#end
+#if ($project.properties.noticeStatement)
+ $project.properties.noticeStatement
+#end
Copyright ${projectTimespan}#if($project.organization.name)
$project.organization.name#else The Apache Software Foundation#end
-
-Apache Sling is based on source code originally developed
+Apache Sling is based on source code originally developed
by Day Software (http://www.day.com/).
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
Review comment:
Please remove this whitespace-only change.
##########
File path: src/main/resources/META-INF/NOTICE.vm
##########
@@ -18,14 +18,19 @@
##
#if ($projectName)$projectName#else${project.name}#end
+#if ($project.properties.noticeStatement)
+ $project.properties.noticeStatement
+#end
Copyright ${projectTimespan}#if($project.organization.name)
$project.organization.name#else The Apache Software Foundation#end
-
-Apache Sling is based on source code originally developed
+Apache Sling is based on source code originally developed
Review comment:
Please remove this whitespace-only change.
##########
File path: src/main/resources/META-INF/NOTICE.vm
##########
@@ -18,14 +18,19 @@
##
#if ($projectName)$projectName#else${project.name}#end
+#if ($project.properties.noticeStatement)
Review comment:
Is this picked up from the pom.xml properties? Also, ca you please move
this to the end of the file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
