[ 
https://issues.apache.org/jira/browse/SLING-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114960#comment-17114960
 ] 

Timothee Maret edited comment on SLING-9465 at 5/23/20, 10:05 PM:
------------------------------------------------------------------

Pushed another approach based on configuration listener in PR 
[#30|https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/30].
 It is untested but functional and descriptive enough to show the pattern. The 
DistributionPublisherConfigured service gets registered only once, when a 
DistributionPublisher config has been created. Adding/removing 
DistributionPublisher configurations won't deactivate the DiscoveryService. 
This option may suffer inconsistencies due to missing events (unless there's a 
way to ensure the listener is registered before the event are fired).


was (Author: marett):
Pushed another approach based on configuration listener in PR 
[#30|https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/30].
 It is untested but functional and descriptive enough to show the pattern. The 
DistributionPublisherConfigured service gets registered only once, when a 
DistributionPublisher config has been created. Adding/removing 
DistributionPublisher configurations won't deactivate the DiscoveryService. 
This option is more stable than PR #29 but may suffer missing events (unless 
there's a way to ensure the listener is registered before the event are fired).

> DiscoveryService is activated on all services
> ---------------------------------------------
>
>                 Key: SLING-9465
>                 URL: https://issues.apache.org/jira/browse/SLING-9465
>             Project: Sling
>          Issue Type: Bug
>          Components: Content Distribution
>            Reporter: Timothee Maret
>            Assignee: Timothee Maret
>            Priority: Major
>             Fix For: Content Distribution Journal Core 0.1.12
>
>
> The DiscoveryService service is only required on services running the 
> DistributionPublisher agents. The DiscoveryServices consumes resources 
> (connections, data volume) which should be avoided.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to