[ 
https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120317#comment-17120317
 ] 

Carsten Ziegeler edited comment on SLING-9489 at 6/1/20, 7:09 AM:
------------------------------------------------------------------

Thinking about this a little bit more, I can see some value in an analyser 
which compares artifacts (I assume the use case is about that):
- By default, the analyser compares the bundles, it can be configured with the 
name of an extension, to compare the artifacts in that extension
- if the specified extension does not exist -> error; if the specified 
extension is not of type artifacts -> error
- the analyser can be configured to fail if the artifacts are the same, or if 
the artifacts differ - not sure what the default should be. This configuration 
is probably a MODE (instead of a boolean) with the values:
- SAME : Passes if the artifacts are the same, including version
- SIMILAR : Passes if the artifacts are the same, ignoring version
- DIFFER : Passes if the artifacts are different (an artifact with different 
versions is considered to be different)

There is one problem with an analyser  - an analyser only acts on a single 
feature; so the second feature needs to be a configuration to the analyser

WDYT?



was (Author: cziegeler):
Thinking about this a little bit more, I can see some value in an analyser 
which compares artifacts (I assume the use case is about that):
- By default, the analyser compares the bundles, it can be configured with the 
name of an extension, to compare the artifacts in that extension
- if the specified extension does not exist -> error; if the specified 
extension is not of type artifacts -> error
- the analyser can be configured to fail if the artifacts are the same, or if 
the artifacts differ - not sure what the default should be. This configuration 
is probably a MODE (instead of a boolean) with the values:
- SAME : Passes if the artifacts are the same, including version
- SIMILAR : Passes if the artifacts are the same, ignoring version
- DIFFER : Passes if the artifacts are different (an artifact with different 
versions is considered to be different)

WDYT?


> Make it possible to compare parts of feature models
> ---------------------------------------------------
>
>                 Key: SLING-9489
>                 URL: https://issues.apache.org/jira/browse/SLING-9489
>             Project: Sling
>          Issue Type: New Feature
>          Components: Feature Model, Maven Plugins and Archetypes
>    Affects Versions: slingfeature-maven-plugin 1.3.4
>            Reporter: A. J. David Bosschaert
>            Assignee: A. J. David Bosschaert
>            Priority: Major
>             Fix For: slingfeature-maven-plugin 1.3.6
>
>
> We need a mojo that allows the comparison of parts of a feature model. If 
> these parts are not equal the mojo should fail the build.
> Right now comparing extensions would be a good start. But comparing 
> configurations or bundles would also be good.
> Key is that not everything needs to be compared. The configuration in the 
> pom.xml should specify what is being compared.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to