[
https://issues.apache.org/jira/browse/SLING-9479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124857#comment-17124857
]
Bertrand Delacretaz edited comment on SLING-9479 at 6/3/20, 10:58 AM:
----------------------------------------------------------------------
I read the GraphQL spec once again (always a good thing to do) and found about
Schema Directives which are much better than structured comments to declare our
fetchers.
I have modified the code to use those and the result looks good to me, marking
this issue won't fix accordingly.
More info in the "DataFetcher selection with Schema Directives" section of the
[GraphQL Core
README|https://github.com/apache/sling-org-apache-sling-graphql-core].
was (Author: bdelacretaz):
I read the GraphQL spec once again (always a good thing to do) and found about
Schema Directives which are much better than structure comments to declare our
fetchers.
I have modified the code to use those and the result looks good to me, marking
this issue won't fix accordingly.
More info in the "DataFetcher selection with Schema Directives" section of the
[GraphQL Core
README|https://github.com/apache/sling-org-apache-sling-graphql-core].
> GraphQL fetcher comments convert to headings in GraphiQL docs
> -------------------------------------------------------------
>
> Key: SLING-9479
> URL: https://issues.apache.org/jira/browse/SLING-9479
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Minor
>
> The GraphQL core currently uses comments like this to map fields to
> DataFetchers:
> {code}
> ## fetch:samples/seeAlso
> {code}
> A common tool to look at those schemas is GraphiQL, which converts such
> comments to headings, considering them to be Markdown.
> We should switch to a less intrusive marker that converts nicely to Markdown.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
