On Thu, 2020-06-04 at 09:30 -0700, Andreas Schaefer wrote: > Hi Robert > > Sorry for the late reply but I was busy yesterday. > > Anyhow I fixed that issue and committed it. You forgot to add the > <generatedFeatures/> folders to the configuration to make sure that > later generated features are picked up.
Great, thanks a lot Andy! (FTR, this was [1]). Robert [1]: https://github.com/apache/sling-org-apache-sling-starter/pull/9/commits/c6f4c488 > > - Andy > > > On Jun 3, 2020, at 2:07 PM, Robert Munteanu <[email protected]> > > wrote: > > > > Hi, > > > > I am looking into SLING-9498 [1] which aims to generate a feature > > model > > on the fly in the Sling Starter. The code is mostly working [2] but > > suffers from the fact that the feature files generated by the > > sling- > > feature-sling-feature-converter-maven-plugin and written to disk > > are > > not visible to the slingfeature-maven-plugin in the same build. > > > > They are actually visible in a subsequent build, so `mvn package` > > would > > work starting with the second attempt. Is this something I > > misconfigured in the pom, or the code does not support that? If > > it's a > > code problem, is it something that can be changed with reasonable > > effort? I familiarised myself a bit with the codebase but I'm not > > sure > > if we should add a mojo to re-read the feature files from disk or > > maybe > > have the converter plugin depend on the main slingfeature plugin > > and > > tell it of the new features. > > > > Thanks, > > Robert > > > > > > [1]: https://issues.apache.org/jira/browse/SLING-9498 > > [2]: > > https://github.com/apache/sling-org-apache-sling-starter/pull/9 > >
