DominikSuess commented on a change in pull request #6:
URL:
https://github.com/apache/sling-org-apache-sling-commons-log/pull/6#discussion_r436506015
##########
File path:
src/main/java/org/apache/sling/commons/log/logback/internal/config/LoggerManagedServiceFactory.java
##########
@@ -20,17 +20,23 @@
import java.util.Dictionary;
+import org.apache.sling.commons.log.logback.internal.LogConfigManager;
import org.osgi.service.cm.ManagedServiceFactory;
class LoggerManagedServiceFactory extends LogConfigurator implements
ManagedServiceFactory {
+ public static final String LOG_FILE_DEFAULT = "logs/error.log";
+
public String getName() {
return "Logger configurator";
}
public void updated(String pid, @SuppressWarnings("rawtypes") Dictionary
configuration)
throws org.osgi.service.cm.ConfigurationException {
try {
+ if (configuration.get(LogConfigManager.LOG_FILE) == null) {
Review comment:
@cziegeler please recheck
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
