Hi Andy,

On Wed, Jun 10, 2020 at 7:14 PM Andreas Schaefer
<[email protected]> wrote:
>
> I will try to fit into my use case....I am thinking of having big files or 
> images than then later are streamed
> to the caller outside of Sling...

My current use cases are about small String inputs and outputs, so I
haven't addressed the multi-part and large data thing so far.

I'm planning to make a release of that servlet helpers module in a few
days along with the GraphQL core that uses it with small amounts of
input and output, but it's fine to add what you need later, I think
that would be useful!

> ...Also the current code from GitHub is having the checkStatus() on the 
> execute(). I think that having a separate
> method (checkStatus()) is better than having on the execute()...

I had that first and then moved to checking status as part of
execute() to make sure people don't forget to do that.

However I agree that a separate checkStatus method makes things more
obvious. I'll re-add that method but add an automatic check for 200
status before providing any response data to the client, unless status
has been checked already, to make sure status is indeed checked.

> ...I think we also should support multiple Status to be accepted...

-Bertrand

Reply via email to