rombert commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/1#issuecomment-647501018
@alldaysunshine - I've released the jcr.resource bundle with your changes ( https://github.com/apache/sling-org-apache-sling-jcr-resource/commit/9902106a166b8d81aadbd28b752103e1844e2367 ) and incorporated it into the Sling Starter ( https://github.com/apache/sling-org-apache-sling-starter/commit/423c6b4767e8de782bdd21876ac026df05ac5f70 ). However, I still get test failures with your PR applied - ``` [ERROR] Failures: [ERROR] VersionParameterTest.testVersionParameterWithChildNode:136->HttpTestBase.getContent:419->HttpTestBase.getContent:424->HttpTestBase.getContent:432->HttpTestBase.getContent:457 Expected status 200 for http://localhost:41000/sling-tests/1592830284798/185_1592830284800/childFile;v='1.0' (content=<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> ``` Can you double-check that the test is correct? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
