Hi Andy and thanks for stepping up with a new release. I asked earlier about checking in the FAR file to the git repository. I guess it was missed due to the non-descript subject line, sorry about that
https://lists.apache.org/thread.html/r253ae564eadb877fce0af52b6f5f7a04b0b527dbd7bb82c4324b9c8e%40%3Cdev.sling.apache.org%3E As a general note, I think we should be wary of checking in binaries to git. With a 80 MB binary file cloning is slower, and that affects developers, CI servers, and potentially others. Moreover, with the nature of Git, these blobs will stay in the repository forever, and refreshing the FAR file 10 times will yield a 800MB payload, which is really large. Also, the release artifacts contain it as well, including the source release, which IMO does not make that much sense, and it's putting pressure on our mirrors. https://repository.apache.org/content/repositories/orgapachesling-2288/org/apache/sling/org.apache.sling.kickstart/0.0.4/ I am not sure ATM if it is actually a problem in a legal sense to include a jar file in a source release. However, I think it is not fully in the spirit of a source release. Could this binary file be pulled in at runtime instead? Thanks, Robert On Mon, 2020-06-22 at 14:24 -0700, Andreas Schaefer wrote: > Hi, > > For most part this is a release to catch up with the changes / > improvements of the Feature Model as a whole like support for Feature > Archives and upgrading to newer releases. > > NOTE: due to the dependencies of Kickstart Project to the Kickstart > Maven Plugin and vice versa there could be some failures in the > Jackson tests. > > We solved 2 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12348280 > https://issues.apache.org/jira/projects/SLING/versions/12348424 > > There are still some outstanding issues: > https://issues.apache.org/jira/projects/SLING/versions/12348423 > > This was moved to the next release as this was not that important as > the user > can use '-s' flag to accomplish the same thing. > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2288 > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2288 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Cheers - Andy Schaefer
