[
https://issues.apache.org/jira/browse/SLING-9577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155308#comment-17155308
]
Christian Schneider commented on SLING-9577:
--------------------------------------------
I do not consider this a valid -1 as you were not able to explain how my change
is worse than the current code. Especially to explain why it would be so bad
that it needs a blocking -1 that holds my progress for 11 days.
The worst case behaviour of both new and old code is the same (unbounded
seeding thread). I will thoroughly test this and if I see no issues I intend to
merge.
> Switch back to seeding thread
> -----------------------------
>
> Key: SLING-9577
> URL: https://issues.apache.org/jira/browse/SLING-9577
> Project: Sling
> Issue Type: Improvement
> Components: Content Distribution
> Affects Versions: Content Distribution Journal Core 0.1.16
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> The current code uses a combination of seeding thread, persisting and loading
> offsets from sling repo and sending single seeding messages.
> In sum this means we send at least one seeding message (seeding thread) on
> first run and one seeding message on following runs.
> I propose to switch back to a pure seeding thread solution and make sure it
> terminates correctly. This solution should in almost all cases also just send
> 1 message and is a lot simpler.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
