[
https://issues.apache.org/jira/browse/SLING-9587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157005#comment-17157005
]
Dominik Süß commented on SLING-9587:
------------------------------------
[~rombert] - as I don't know how the coverage rules are controlled I added
nonfunctional code coverage for the getters of the anonymous VaultPackage
implementation. This is necessary due to the traverse handling of nested
packages which will close the files in between and therefore needs to close the
vault packages before I get to sort them. A refactoring on the filehandling
would be far more intrusive so I used these holders as the filevault
implementation of DependencyUtil only requires the ID and Dependencies
information to calculate the order.
> Content-packages ref not ordered by dependencies for nested packages
> --------------------------------------------------------------------
>
> Key: SLING-9587
> URL: https://issues.apache.org/jira/browse/SLING-9587
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
> Affects Versions: Content-Package to Feature Model Converter 1.0.10
> Reporter: Dominik Süß
> Priority: Critical
> Fix For: Content-Package to Feature Model Converter 1.0.12
>
>
> The order logic of the cp converter currently only considers the highest
> level packages passed into the converter - installing the identified packages
> of type content based on the content-refs subsequently can fail if the
> packages as picked up by traversal are not in the order of their
> dependencies.
> As the order can be calculated via DependencyUtil the output just needs to be
> ordered after all entries have been calculated instead of passing to the
> writer right away.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
